[riscv-port-jdk17u:riscv-port] RFR: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule [v2]
fyang at openjdk.org
Tue Mar 21 08:43:25 UTC 2023
On Tue, 21 Mar 2023 08:36:12 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:
>> Please review this backport to riscv-port-jdk17u.
>> Backport of [JDK-8301313](https://bugs.openjdk.org/browse/JDK-8301313).
>> The original patch cannot be directly applied because of the line number, but there are no other additional changes.
>> The error `C2: assert(false) failed` mentioned in the original issue may require foreign api to reproduce, which is not available in jdk17u, but the same problem actually exists in jdk17u.
>> - Tier1-3 passed without new failure on unmacthed (release).
> Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> - Merge branch 'riscv-port' into backport-JDK-8301313
> - Fix format and ins_pipe
> - 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule
> Backport-of: 3ad6aef1496de914b70f00005465e4b22f248d4f
OK. I see the C2 transformation code leading to the original issue is also there in jdk17u.
Marked as reviewed by fyang (Committer).
PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/17#pullrequestreview-1349923114
More information about the riscv-port-dev