[riscv-port-jdk17u:riscv-port] RFR: 8294366: RISC-V: Partially mark out incompressible regions

Vladimir Kempik vkempik at openjdk.org
Tue Mar 28 12:35:08 UTC 2023

On Tue, 28 Mar 2023 12:06:31 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/assembler_riscv.hpp line 2119:
>>> 2117: //
>>> 2118: //      CompressibleRegion cr(_masm);
>>> 2119: //      __ add(...);       // this instruction will be compressed into 'c.and' when possible
>> Comments use `c.and`, but the example asm uses `add`, is this a typo?
> Indeed typos, thanks for the catch. The `openjdk/jdk` repo also has these two typos. Not sure about the rule of backporting: should I fix it here and then file another patch on `openjdk/jdk`, or?

There is better way.
1) fix typos in opejdk/jdk
2) combine two backports into one commit with two issue messages in it


1) proper commit/backport ( with typos fixed) in 17u
2) fix typos in openjdk/jdk but add 17-na label to the bug in jbs


PR Review Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/28#discussion_r1150533199

More information about the riscv-port-dev mailing list