[riscv-port-jdk17u:riscv-port] RFR: 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler

Fei Yang fyang at openjdk.org
Mon May 22 01:41:14 UTC 2023


On Fri, 19 May 2023 03:58:51 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301036](https://bugs.openjdk.org/browse/JDK-8301036).
> The original patch cannot be directly applied because of the missing whitespace between `offset` and `=`:
> https://github.com/openjdk/riscv-port-jdk17u/blob/9b88e8e65771a7022b2ce3d7cd89281dea9ce975/src/hotspot/cpu/riscv/macroAssembler_riscv.hpp#L889
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Looks good.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/54#pullrequestreview-1435649082


More information about the riscv-port-dev mailing list