[riscv-port-jdk11u:riscv-port] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v10]
Gui Cao
gcao at openjdk.org
Thu Feb 8 02:59:09 UTC 2024
On Wed, 7 Feb 2024 16:51:59 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:
> > Hi, Maybe you forgot to add issue: 8282306, 8301313, 8308277, 8310873
>
> 4. For [JDK-8282306: os::is_first_C_frame(frame*) crashes on invalid link access](https://bugs.openjdk.org/browse/JDK-8282306): the original RISC-V initial patch on JDK19 [contains this patch](https://github.com/openjdk/jdk/blob/5905b02c0e2643ae8d097562f181953f6c88fc89/src/hotspot/cpu/riscv/frame_riscv.inline.hpp#L146-L149). Then, the issue got backported to [JDK11u](https://github.com/openjdk/jdk11u-dev/commit/7c664bcd82cf2a13c9fdcd803345c6095e4d3873). So, after backporting the RISC-V backend, they naturally merged together without changes needed. Subtle, but adding this issue to the list of this PR is fine I think, by aligning with the JDK17u PR.
> 5. For [JDK-8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule](https://bugs.openjdk.org/browse/JDK-8301313): Sorry I don't get this one... The [original code](https://github.com/openjdk/jdk/commit/3ad6aef1496de914b70f00005465e4b22f248d4f) here doesn't seem to exist in this PR?
> 6. For 8308277: Discussed in the 3rd item and it is fine.
> 7. For [JDK-8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V](https://bugs.openjdk.org/browse/JDK-8310873): The [upstream code](https://github.com/openjdk/jdk/commit/87e6fab2c498558d4593f6c0537c998a61779aaf) doesn't seem to exist in this initial patch, which is the same as the 5th item.
>
Thank you for your reply, I checked again and you are right. Happy Lunar New Year!
-------------
PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/3#issuecomment-1933285872
More information about the riscv-port-dev
mailing list