[riscv-port-jdk11u:riscv-port] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v10]

Fei Yang fyang at openjdk.org
Mon Feb 19 08:41:16 UTC 2024


On Thu, 1 Feb 2024 06:49:00 GMT, kuaiwei <duke at openjdk.org> wrote:

>> It's the initial patch based on the JDK19 initial load https://github.com/openjdk/jdk/commit/5905b02c0e2643ae8d097562f181953f6c88fc89, and revert patches not required in JDK11u. The testing is running on a linux riscv board. There are some failed cases and we are working on fix them , the progress will updated.
>> 
>> Thanks the contribution of OpenJDK community and hard working of @zhengxiaolinX .
>> 
>> - [x]  slowdebug/fastdebug/release build
>> - [x] Benchmark: SPECJbb2015, Renaissance
>> - [x]  Tier1 tests
>> - [x] Tier2 tests
>> - [x] Tier3 tests
>> - [ ] Tier4 tests
>
> kuaiwei has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 145 commits:
> 
>  - Remove unused zSyscall_linux_riscv.hpp
>  - Merge riscv-port
>  - Merge branch 'port_jdk11u_initial_patch' of github.com:kuaiwei/riscv-port-jdk11u into kw_initial_patch
>  - Merge branch 'openjdk:master' into port_jdk11u_initial_patch
>  - Merge riscv-port
>  - Revert JDK-8247533: SA stack walking sometimes fails with sun.jvm.hotspot.debugger.DebuggerException: get_thread_regs failed for a lwp
>  - Fix test error after port 8295926
>  - 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
>    
>    Reviewed-by: yadongwang, fyang
>  - 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub
>    
>    Reviewed-by: yadongwang, fjiang, shade, vkempik
>  - Merge riscv-port
>  - ... and 135 more: https://git.openjdk.org/riscv-port-jdk11u/compare/a0a61dda...4b01e137

> > > > > It looks https://bugs.openjdk.org/browse/JDK-8247533 can fix the Clhsdb test error
> > > > 
> > > > 
> > > > Better to backport this fix in jdk11u-dev upstream if it really resolves this error. Then we can merge master and bring it to our riscv-port-jdk11u repo.
> > > 
> > > 
> > > I may revert the change. Because I find the root cause of Clhsdb test failure is ptrace function is not fully supported in linux riscv. For example, PTRACE_GETREGS. We cat set kernel parameter "sysctl -w kernel.yama.ptrace_scope=1" to pass these tests.
> > 
> > 
> > @kuaiwei : I think the correct way to fix those Clhsdb test failure is to backport fix for https://bugs.openjdk.org/browse/JDK-8307955. I see they are passing with the following backport patch: [8307955-11u-backport.diff.txt](https://github.com/openjdk/riscv-port-jdk11u/files/14239024/8307955-11u-backport.diff.txt)
> 
> It's a platform independent change. Do we need backport it to jdk11u upstream?
> 
> I can pass CLHSDB tests by changing sys parameter.
> 
> ```shell
> sysctl -w kernel.yama.ptrace_scope=1
> ```

Yeah, I think you are right. It's better to fix that in 11u upstream and merge to this repo. 
I also performed tier1-3 and hotspot:tier4 tests on unmatched & licheepi-4a boards. Still good. 
So I intend to think this is OK to go if there are no other opinions.

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/3#issuecomment-1951949859


More information about the riscv-port-dev mailing list