[sctp-dev] Request for review: 6916890
Christopher Hegarty -Sun Microsystems Ireland
Christopher.Hegarty at Sun.COM
Mon Jan 18 05:50:53 PST 2010
Alan Bateman wrote:
> .....
> In SctpChannelImpl it looks like you can move lines 985-988 to after
> you've checked if the user's buffer is direct or not - that would avoid
> fetching the position and limit twice for the direct buffer case. Same
> comment for SctpMultiChannelImpl. Otherwise the implementation change
> looks right to me. For the tests, one suggestion is to go a step further
> and verify the received message. Without that it only checks the return
> value and that the buffer position has been updated.
Thanks Alan for the review and the comments. I made the changes and
updated the webrev:
http://cr.openjdk.java.net/~chegar/6916890/webrev.1/
-Chris.
>
> -Alan.
More information about the sctp-dev
mailing list