[sctp-dev] Request for review: 6916890

[Alan Bateman]

Christopher Hegarty -Sun Microsystems Ireland wrote:
>
>
> Alan Bateman wrote:
>> .....
>> In SctpChannelImpl it looks like you can move lines 985-988 to after 
>> you've checked if the user's buffer is direct or not - that would 
>> avoid fetching the position and limit twice for the direct buffer 
>> case. Same comment for SctpMultiChannelImpl. Otherwise the 
>> implementation change looks right to me. For the tests, one 
>> suggestion is to go a step further and verify the received message. 
>> Without that it only checks the return value and that the buffer 
>> position has been updated.
>
> Thanks Alan for the review and the comments. I made the changes and 
> updated the webrev:
>   http://cr.openjdk.java.net/~chegar/6916890/webrev.1/
Looks OK to me.

-Alan.