[security-dev 00409]: Re: xml-stylesheet data files usage in tests removed by fsg.sh

Mark Wielaard mark at klomp.org
Sun Nov 16 12:47:11 PST 2008


Hi Andrew,

On Sun, 2008-11-16 at 13:07 +0100, Mark Wielaard wrote:
> On Sun, 2008-11-16 at 00:51 +0000, Andrew John Hughes wrote:
> > Interestingly, I don't think these tests are in OJ7.  At least, I
> > don't recall seeing these failures.
> 
> The files are certainly there under 7, and they are removed by the
> fsg.sh script. The Generation and Validation Tests that use them are
> also there. I'll do a build and a make check to see what is happening
> there.

How strange, these tests are there, but aren't run by our make check
jtreg run:

fail   ---    javax/xml/crypto/dsig/GenerationTests.java
fail   ---    javax/xml/crypto/dsig/ValidationTests.java
pass   ---    javax/xml/crypto/dsig/keyinfo/KeyInfo/Marshal.java

But this one is run:

javax/xml/crypto/dsig/SecurityManager/XMLDSigWithSecMgr.java
Passed. Execution successful

Puzzling...

After some testing I found it comes from the usage of -ignore:quiet
And that is probably the hint we need, because the new jtreg release
notes said: "Reduce false positives when setting keywords from test
description."

Indeed, using the jtreg embedded in icedtea6 inside icedtea[7] fixes it.
Most likely this was caused by the usage of -XDignore.symbol.file inside
the GenerationTests.java and ValidationTests.java files.

So, please forward port the jtreg changed from icedtea6 to icedtea[7],
then you can see these two tests also fail :)

This was the patch that added the new jtreg to icedtea6:
http://icedtea.classpath.org/hg/icedtea6/rev/76b5306fead0
(To see the fix, search for IGNORE_ACTION)
You will also want the -samevm support for langtools to make things go
much quicker:
http://icedtea.classpath.org/hg/icedtea6/rev/688efd120766

Cheers.

Mark




More information about the security-dev mailing list