[security-dev 01428]: Re: Please review patch for regression test sun/security/tools/keytool/StartDate

[Max (Weijun) Wang]

Hi Pavel

Your change looks fine.

The test in OpenJDK was already fixed long time ago:

   http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6643094
   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59

I'll create a sub bug id targeting OpenJDK-6 and backport the fix.

Thanks
Max

On Dec 3, 2009, at 9:24 PM, Pavel Tisnovsky wrote:

> Hi,
>
> patch for regression test sun/security/tools/keytool/StartDate.java  
> (included in OpenJDK6) is exposed at
>
> http://cr.openjdk.java.net/~ptisnovs/StartDateTest/
>
> and prepared for review.
>
> This patch ensures, that this test does not fail on December(s) due  
> to incorrect comparison of two months (12 != 0).
>
> Can you please review and possibly approve this patch?
>
> Pavel Tisnovsky
> Red Hat