[security-dev 01435]: Re: hg: jdk7/tl/jdk: 6907177: Update jdk tests to remove unncessary -source and -target options

[Kelly O'Hair]

Andrew John Hughes wrote:
> 2009/12/4  <joe.darcy at sun.com>:
>> Changeset: 1755493c5774
>> Author:    darcy
>> Date:      2009-12-03 18:19 -0800
>> URL:       http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1755493c5774
>>
>> 6907177: Update jdk tests to remove unncessary -source and -target options
>> Reviewed-by: ohair
>>
>> ! test/demo/jvmti/hprof/CpuOldTest.java
>> ! test/demo/jvmti/hprof/CpuSamplesTest.java
>> ! test/demo/jvmti/hprof/CpuTimesDefineClassTest.java
>> ! test/demo/jvmti/hprof/CpuTimesTest.java
>> ! test/demo/jvmti/hprof/HeapAllTest.java
>> ! test/demo/jvmti/hprof/HeapBinaryFormatTest.java
>> ! test/demo/jvmti/hprof/HeapDumpTest.java
>> ! test/demo/jvmti/hprof/HeapSitesTest.java
>> ! test/demo/jvmti/hprof/OptionsTest.java
>> ! test/java/io/Serializable/enum/array/Test.java
>> ! test/java/io/Serializable/enum/badResolve/Write.java
>> ! test/java/io/Serializable/enum/basic/Test.java
>> ! test/java/io/Serializable/enum/classObject/Test.java
>> ! test/java/io/Serializable/enum/constantSubclasses/Write.java
>> ! test/java/io/Serializable/enum/ignoreSerializationFields/Test.java
>> ! test/java/io/Serializable/enum/ignoreSerializationMethods/Test.java
>> ! test/java/io/Serializable/enum/mismatchedTypecode/Test.java
>> ! test/java/io/Serializable/enum/missingConstant/Write.java
>> ! test/java/io/Serializable/enum/unshared/Test.java
>> ! test/java/lang/Boolean/MakeBooleanComparable.java
>> ! test/java/lang/Class/Cast.java
>> ! test/java/lang/Class/IsEnum.java
>> ! test/java/lang/Class/asSubclass/BasicUnit.java
>> ! test/java/lang/ClassLoader/Assert.sh
>> ! test/java/lang/Integer/BitTwiddle.java
>> ! test/java/lang/Long/BitTwiddle.java
>> ! test/java/lang/Math/Atan2Tests.java
>> ! test/java/lang/Math/IeeeRecommendedTests.java
>> ! test/java/lang/Math/PowTests.java
>> ! test/java/lang/Math/TanTests.java
>> ! test/java/lang/Runtime/exec/WinCommand.java
>> ! test/java/lang/Thread/GenerifyStackTraces.java
>> ! test/java/lang/Thread/UncaughtExceptions.sh
>> ! test/java/lang/annotation/UnitTest.java
>> ! test/java/lang/annotation/package-info.java
>> ! test/java/lang/management/CompositeData/MemoryNotifInfoCompositeData.java
>> ! test/java/lang/management/CompositeData/ThreadInfoCompositeData.java
>> ! test/java/lang/management/ManagementFactory/MXBeanProxyTest.java
>> ! test/java/lang/management/ManagementFactory/PlatformMBeanServerTest.java
>> ! test/java/lang/management/ManagementFactory/ProxyExceptions.java
>> ! test/java/lang/management/ManagementFactory/ProxyTypeMapping.java
>> ! test/java/lang/management/ManagementFactory/ValidateOpenTypes.java
>> ! test/java/lang/management/RuntimeMXBean/GetSystemProperties.java
>> ! test/java/lang/management/RuntimeMXBean/TestInputArgument.sh
>> ! test/java/lang/reflect/Constructor/GenericStringTest.java
>> ! test/java/lang/reflect/Field/GenericStringTest.java
>> ! test/java/lang/reflect/Generics/StringsAndBounds.java
>> ! test/java/lang/reflect/Generics/TestC1.java
>> ! test/java/lang/reflect/Generics/TestC2.java
>> ! test/java/lang/reflect/Generics/TestN1.java
>> ! test/java/lang/reflect/Generics/exceptionCauseTest.java
>> ! test/java/lang/reflect/Generics/getAnnotationTest.java
>> ! test/java/lang/reflect/Method/Equals.java
>> ! test/java/lang/reflect/Method/GenericStringTest.java
>> ! test/java/math/BigDecimal/DivideTests.java
>> ! test/java/math/BigDecimal/IntegralDivisionTests.java
>> ! test/java/math/BigDecimal/PowTests.java
>> ! test/java/math/BigDecimal/ToPlainStringTests.java
>> ! test/java/math/BigDecimal/ZeroScalingTests.java
>> ! test/java/math/RoundingMode/RoundingModeTests.java
>> ! test/java/net/ProxySelector/ProxyTest.java
>> ! test/java/net/URL/PerConnectionProxy.java
>> ! test/java/security/cert/PKIXBuilderParameters/InvalidParameters.java
>> ! test/java/security/cert/PKIXParameters/InvalidParameters.java
>> ! test/java/util/AbstractList/CheckForComodification.java
>> ! test/java/util/Collections/AddAll.java
>> ! test/java/util/Collections/Disjoint.java
>> ! test/java/util/Collections/Frequency.java
>> ! test/java/util/EnumMap/EnumMapBash.java
>> ! test/java/util/EnumSet/AllOf.java
>> ! test/java/util/EnumSet/ComplementOf.java
>> ! test/java/util/EnumSet/EnumSetBash.java
>> ! test/java/util/EnumSet/JumboRange.java
>> ! test/java/util/EnumSet/Range.java
>> ! test/java/util/Formattable/StockName.java
>> ! test/java/util/IdentityHashMap/ToString.java
>> ! test/java/util/Locale/Bug4175998Test.java
>> ! test/java/util/UUID/UUIDTest.java
>> ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java
>> ! test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java
>> ! test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java
>> ! test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java
>> ! test/java/util/concurrent/ConcurrentHashMap/MapCheck.java
>> ! test/java/util/concurrent/ConcurrentHashMap/MapLoops.java
>> ! test/java/util/concurrent/Exchanger/ExchangeLoops.java
>> ! test/java/util/concurrent/ExecutorCompletionService/ExecutorCompletionServiceLoops.java
>> ! test/java/util/concurrent/FutureTask/CancelledFutureLoops.java
>> ! test/java/util/concurrent/atomic/VMSupportsCS8.java
>> ! test/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java
>> ! test/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java
>> ! test/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java
>> ! test/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java
>> ! test/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java
>> ! test/sun/management/AgentCheckTest.java
>> ! test/sun/security/util/Oid/S11N.sh
>> ! test/sun/tools/jconsole/ResourceCheckTest.sh
>>
>>
> 
> Was this really necessary? The options, as far as I can see, were
> doing no harm but this change means that a compiler that defaults to a
> version < 1.5 (e.g. ecj) will now fail to compile the tests.

I thought these tests were primarily for the jdk we are building,
a jdk6 jdk, containing a jdk6 javac.

Are you saying that some openjdk6 builds out there do not contain the
langtools version of javac?

Or are you just requesting that we provide tests in openjdk6 for all
javac compilers?

-kto