[security-dev 00570]: inefficient Des3DkCrypto/DigestMD5Base.setParityBit()

Christian Thalinger Christian.Thalinger at Sun.COM
Tue Feb 17 15:30:14 UTC 2009


[I was told on core-libs-dev that I should probably send this one to
this list.]

Hi!

While looking at the bitCount() thing I mentioned in the other thread, I
noticed that Des3DkCrypto and DigestMD5Base are using a very inefficient
implementation of setParityBit().  The one from DESKeyGenerator is much
better and uses Integer.bitCount(), which could benefit from a
population-count intrinsic.

Should I file a CR or even propose a patch?

-- Christian




More information about the security-dev mailing list