[security-dev 00573]: Re: Code review request: 6780416: New keytool commands/options: -gencert, -printcertreq, -ext

Max (Weijun) Wang Weijun.Wang at Sun.COM
Wed Feb 18 09:34:34 UTC 2009


If you are more familiar with the standard webrev format, I have a  
copy here:

http://cr.openjdk.java.net/~weijun/6780416/webrev.00/

On Feb 18, 2009, at 5:05 PM, Max (Weijun) Wang wrote:

> Hi All
>
> Can you take a review of this RFE?
>
>  6780416: New keytool commands/options: -gencert, -printcertreq, -ext
>  bug: http://bugs.sun.com/view_bug.do?bug_id=6780416
>  webrev: http://hgrev.appspot.com/show?id=3077
>
> The spec of the 3 new commands/options is inside the evaluation  
> section of the bug report.
>
> The fix is mainly on KeyTool.java, with changes in Resources.java  
> for l10n strings. Some X.509 files are changed to provide new  
> constructor, new constants etc. A new class  
> SubjectInfoAccessExtension.java is created for the extension. The  
> KeyToolTest.java regression test are updated to cover the new  
> commands/options.
>
> If you find the webrev too long, you might only review a part of it.
>
> Thanks
> Max
>
>




More information about the security-dev mailing list