[security-dev 01415]: Re: hg: jdk7/tl/jdk: 3 new changesets

[Bob Lee]

On Wed, Oct 21, 2009 at 1:02 PM, <xueming.shen at sun.com> wrote:

> 4206909: want java.util.zip to work for interactive use (Z_SYNC_FLUSH)
> Summary: Add sync_flush option into Deflater/DefalterOutputStream
> Reviewed-by: martin, alanb
>
> ! src/share/classes/java/util/zip/Deflater.java
> ! src/share/classes/java/util/zip/DeflaterOutputStream.java
> ! src/share/native/java/util/zip/Deflater.c
> + test/java/util/zip/InflateIn_DeflateOut.java
>

Should we use an enum for the flush strategies? It would help separate them
from the compression strategies, and it would make the new method easier to
use because it would be obvious at compile time which values you can pass in
(as opposed to allowing any random int).

Also, we could add a note about how alternate flush strategies can
negatively affect compatibility with tools like WinZip.

Bob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20091124/1dc02bed/attachment.htm>