[security-dev 01240]: Code review request: 6880321 sun.security.provider.JavaKeyStore abuse of OOM Exception handling

Max (Weijun) Wang Weijun.Wang at Sun.COM
Tue Sep 22 00:26:58 PDT 2009


Hi Andrew

Please take a review on this code change:

     http://cr.openjdk.java.net/~weijun/6880321/webrev.00/

Thanks
Max


>
> *Change Request ID*: 6880321
>
> *Synopsis*: sun.security.provider.JavaKeyStore abuse of OOM  
> Exception handling
>
> === *Description*  
> ============================================================
> FULL PRODUCT VERSION :
> 1.6.0.X
>
> A DESCRIPTION OF THE PROBLEM :
> This class catches OOM exceptions and throws Non chainen IOException.
>
> This is a massive abuse of exception handling and hides errors  
> information from the caller.  It also misleads the caller to the  
> reason for the error
>
> EXPECTED VERSUS ACTUAL BEHAVIOR :
> EXPECTED -
> Provider proper chained exceptions or Dont catch OOM errors
>
> REPRODUCIBILITY :
> This bug can be reproduced always.




More information about the security-dev mailing list