[security-dev 01243]: Re: Code review request: 6880321 sun.security.provider.JavaKeyStore abuse of OOM Exception handling

[Xuelei Fan]

Max (Weijun) Wang wrote:
>
> On Sep 22, 2009, at 4:09 PM, Florian Weimer wrote:
>
>> * Max Wang:
>>
>>> Please take a review on this code change:
>>>
>>>    http://cr.openjdk.java.net/~weijun/6880321/webrev.00/
>>
>> This code is still unreliable.  You cannot hide OutOfMemoryError this
>> way.  The error could even be thrown in a completely unrelated thread.
>>
>> There is no really good way to deal with this type of resource
>> exhaustation.  To deal with corrupted files, it is sufficient to grow
>> arrays as the file is read, so you will hit the end of the file before
>> the OOM error occurs.
>
> This sounds better.
Sounds better to me also.

Andrew
>
> Thanks
> Max
>
>>
>> -- 
>> Florian Weimer                <fweimer at bfk.de>
>> BFK edv-consulting GmbH       http://www.bfk.de/
>> Kriegsstraße 100              tel: +49-721-96201-1
>> D-76133 Karlsruhe             fax: +49-721-96201-99
>