Code Review for 6998860

Sean Mullan sean.mullan at
Wed Dec 8 06:19:19 PST 2010

On 12/7/10 8:20 PM, Mandy Chung wrote:
> Hi Sean,
> On 12/7/10 12:47 PM, Sean Mullan wrote:
>> Hi Mandy,
>> Could I get a code review for 6998860:
> Is Providers.getSunProvider() specified to create a new instance of the provider
> every time it's called? I would assume that the runtime should create only one
> single instance of the Sun provider.

Yes, makes sense but that is how it is currently implemented.

> In the comment of the method, this
> method is called in two places.
> // Return to Sun provider or its backup.
> // This method should only be called by
> // and
> public static Provider getSunProvider() {
> Is it correct to change this method to cache and return a singleton object?

That seems plausible but I'm a bit hesitant to change that if there isn't a 


More information about the security-dev mailing list