review request for 7008713: diamond conversion of kerberos5 and security tools

Weijun Wang weijun.wang at oracle.com
Wed Dec 22 17:45:04 PST 2010


Looks fine.

BTW, what are we supposed to review? Besides going through the patch and 
making sure each change is good, the only thing I can think of is 
looking for lines need coinification but untouched. Made some simple 
greps and found none yet.

I can review the following files you listed for Vinnie:

src/share/classes/com/sun/security/sasl/digest/DigestMD5Client.java
src/share/classes/com/sun/security/sasl/digest/DigestMD5Server.java
src/share/classes/javax/security/sasl/Sasl.java
src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java
src/share/classes/sun/security/util/Cache.java
src/share/classes/sun/security/util/DerIndefLenConverter.java
src/share/classes/sun/security/util/DerInputStream.java
src/share/classes/sun/security/util/DisabledAlgorithmConstraints.java
src/share/classes/sun/security/util/ManifestDigester.java
src/share/classes/sun/security/util/ManifestEntryVerifier.java
src/share/classes/sun/security/util/SignatureFileVerifier.java
test/com/sun/security/sasl/digest/CheckNegotiatedQOPs.java
test/com/sun/security/sasl/digest/NoQuoteParams.java
test/com/sun/security/sasl/ntlm/NTLMTest.java
test/javax/security/sasl/Sasl/PassSysProps.java
test/sun/security/util/Resources/NewNamesFormat.java
test/sun/security/util/Resources/NewResourcesNames.java

i.e. .*/(util|sasl|pkcs12)/.*

Thanks
Max

On 12/23/2010 08:10 AM, Stuart Marks wrote:
> Here's another batch of diamond conversion changes.
>
> Max, can you review this please? Webrev is here:
>
> http://cr.openjdk.java.net/~smarks/reviews/7008713/webrev.0/
>
> Thanks!
>
> s'marks



More information about the security-dev mailing list