review request for 7005608: diamond conversion of JCA and crypto providers

Weijun Wang weijun.wang at oracle.com
Wed Dec 22 18:37:53 PST 2010



On 12/23/2010 10:17 AM, Brad Wetmore wrote:
>
>
> You need to update the Copyright updates on these files to include 2010.
>
> Not having a lot of experience yet with <>, the only ones I wasn't sure
> about were the ones in X509Factor.parseX509orPKCS7Cert. (line 415 & 425)
> I assume it just picks up the outer return type?

I read the byte codes generated, and the parameters on lines 415 and 425 
are not used. Maybe they are good for code readability.

>
> Minor nit, can you add a space in line 221 between
> "BigInteger,BlindingParameters"

I thought the formal style is no-space. At least in Map.java it's public 
interface Map<K,V>.

Max

>
> Looks good otherwise.
>
> Brad
>
>
>
> On 12/22/2010 3:02 PM, Stuart Marks wrote:
>> Hi all,
>>
>> As you may have heard [1], I'm working on updating the JDK libraries to
>> use some Project Coin features. Currently I'm working on converting the
>> library code to use the "diamond" operator for more concise generic
>> creation expressions. Up now is conversion of the JCA and crypto
>> provider code. I'll be moving through other parts of the security
>> libraries in the JDK next.
>>
>> Brad, can you review this chunk of changes? Webrev is here:
>>
>> http://cr.openjdk.java.net/~smarks/reviews/7005608/webrev.0/
>>
>> (This should be substantially the same as the webrev I posted internally
>> yesterday.)
>>
>> Thanks!
>>
>> s'marks
>>
>> [1] http://blogs.sun.com/darcy/entry/project_coin_minty_fresh_libraries



More information about the security-dev mailing list