code review request: 6969292: make DNS lookup for realm/kdc really work

Alan Bateman Alan.Bateman at
Sat Jul 17 01:28:26 PDT 2010

Valerie (Yu-Ching) Peng wrote:
> Looks fine except the following minor nit:
> - Why not return realm on line 1224 after a match is found? Doesn't 
> seem necessary to continue w/ the whole for-loop.
Indeed, looks like it is missing a "break".


More information about the security-dev mailing list