Please review fix for 6951599 (Rename package of security tools for modularization)

Wang Weijun Weijun.Wang at Sun.COM
Thu May 13 22:50:48 PDT 2010


Hi Mandy

Sorry for late comment. My email client on Nokia E71 keeps crashing. (Hope 
it's good this time).

I'm quite sure there are people out there calling KeyTool the same way. 
Also, I feel a little weird that one tool is treated diffrently from 
others.

Is it possible to leave all current class unchanged, and create new 
packages called sun.security.tools.xxx (xxx can be keytool, jarsigner, 
policytool), each with a single Xxx class whose main() simply calls 
sun.securiry.tools.Xxx.main()?

Also, there are 3 Windows-only security tools (kinit, klist, ktab) in 
sun.security.krb5.internal.tools. Should they be isolated the same way?

Thanks
Max

------- Original message -------
> From: Mandy Chung <mandy.chung at oracle.com>
> To: security-dev at openjdk.java.net
> Sent: 14.5.'10,  13:16
>
> I revised the fix to rename the package of keytool instead of jarsigner. 
> Apparently, there are customers who depend on the jarsigner class.
>
> Webrev at:
>   http://cr.openjdk.java.net/~mchung/6951599/webrev.01/
>
> I also updated the copyright year (thanks Brad for pointing that out).
>
> Thanks
> Mandy
>
> Mandy Chung wrote:
>> Hi,
>>
>> Please review the fix for:
>>   6951599: Rename package of security tools for modularization
>>
>> Webrev:
>>  http://cr.openjdk.java.net/~mchung/6951599/webrev.00/
>>
>> Move KeyTool, PolicyTool and JarSigner classes to its own package so 
>> that the classes can be placed in its own module while eliminating the 
>> split package (that requires such modules be locally connected and 
>> loaded by the same class loader).
>>
>> Thanks
>> Mandy
>>
>




More information about the security-dev mailing list