6995424 Code Review Request

[Mandy Chung]

  Hi Sean,

On 11/16/10 5:56 AM, Sean Mullan wrote:
> http://cr.openjdk.java.net/~mullan/6995424/webrev.00/
>

Policy.java:
     I was initially confused with the meaning of 'compatPolicy'.  I 
thought that when 'compatPolicy' is set to true, it means that the 
deprecated javax.security.auth.Policy class or the legacy 
com.sun.security.auth.PolicyFile is used for backward compatibility 
support.  It turns out that it's the reverse as it's set in line 241 and 
295.  Should it be renamed to 'useStandardPolicy' to make it clear?

However, in line 273, javax.security.auth.Policy.setPolicy sets 
compatPolicy to true.  Is the given Policy object a 
javax.security.auth.Policy object?  Should it set it to false?

Probably I'm missing something here:

  276     // maintain backwards compatibility for people who provide
  277     // their own javax.security.auth.Policy implementations


It would help if some comments are added to explain further.

Thanks
Mandy