Code review request for 7035115

Valerie (Yu-Ching) Peng valerie.peng at oracle.com
Mon Apr 18 22:25:18 UTC 2011


Thanks for the review!
Valerie

On 04/14/11 05:49 PM, Weijun Wang wrote:
> Changes look fine.
>
> Are you going to backport the fix to earlier JDKs? Otherwise, you can 
> simplify
>
>    cons = clazz.getConstructor(new Class[] {String.class});
>    Object obj = cons.newInstance(new Object[] {configFile});
>
> to
>
>    cons = clazz.getConstructor(String.class);
>    cons.newInstance(configFile);
>
> Thanks
> Max
>
> On 04/15/2011 07:32 AM, Valerie (Yu-Ching) Peng wrote:
>> Max,
>>
>> Do you have cycles to review this following trivial test bug?
>> 7035115: sun/security/pkcs11/Provider/ConfigShortPath.java compilation
>> failed
>>
>> Webrev at:
>> http://cr.openjdk.java.net/~valeriep/7035115/webrev.00/
>>
>> This only occurs on windows 64-bit machines where SunPKCS11 provider
>> isn't built.
>> This wasn't caught in my previous JPRT job since pkcs11 regression tests
>> aren't run w/ default JPRT settings.
>>
>> Thanks,
>> Valerie




More information about the security-dev mailing list