2nd round code review request: 7055363: jdk_security3 cleanup

Alan Bateman Alan.Bateman at oracle.com
Thu Aug 4 03:32:40 PDT 2011


Weijun Wang wrote:
>
> There are two ways to do this:
>
> 1. Add "@run main/othervm" to all JSSE tests. This means a lot of code 
> changes, but I can automate it.
>
> 2. Create new test set for JSSE. This is what I had done before in
>
>    http://cr.openjdk.java.net/~weijun/7055363/webrev.00/
>
> many changes to Makefile, jprt.properties and jprt.properties in the 
> parent repo.
>
> I'd choose #1. What's your opinion?
>
It's a pity to have so many tests running in othervm mode but I agree 
that #1 is the way to do this. As Kelly says we want to be able to allow 
folks to "jtreg -agentvm" and ultimately they should be able to specify 
the top-level test directory and all tests should pass.

-Alan




More information about the security-dev mailing list