Code review request: 7063647, jsse/runtime, To use synchronized map in key manager

Brad Wetmore bradford.wetmore at oracle.com
Mon Aug 8 17:03:26 PDT 2011


Why do you need the "syncronchized (credentialsMap)" at line 344? 
Aren't all writes done during the constructor init?

Otherwise, looks ok.

Brad


On 8/7/2011 8:43 PM, Xuelei Fan wrote:
> webrev: http://cr.openjdk.java.net/~xuelei/7063647/webrev.00/
>
> SunX509KeyManagerImpl should be multiple thread safe, need to
> synchronize cached map:
>      private Map<String,X509Credentials>  credentialsMap;
>      private Map<String,String[]>  serverAliasCache;
>
> Thanks,
> Xuelei



More information about the security-dev mailing list