Code review request: 7063647, jsse/runtime, To use synchronized map in key manager

Brad Wetmore bradford.wetmore at
Mon Aug 8 17:03:26 PDT 2011

Why do you need the "syncronchized (credentialsMap)" at line 344? 
Aren't all writes done during the constructor init?

Otherwise, looks ok.


On 8/7/2011 8:43 PM, Xuelei Fan wrote:
> webrev:
> SunX509KeyManagerImpl should be multiple thread safe, need to
> synchronize cached map:
>      private Map<String,X509Credentials>  credentialsMap;
>      private Map<String,String[]>  serverAliasCache;
> Thanks,
> Xuelei

More information about the security-dev mailing list