Code review request: 7064075 Security libraries don't build with javac -Xlint:all, -deprecation -Werror

Xuelei Fan xuelei.fan at oracle.com
Wed Aug 10 19:51:23 PDT 2011


On 8/11/2011 7:07 AM, Alexandre Boulgakov wrote:
> Here's an updated webrev:
> http://cr.openjdk.java.net/~mduigou/7064075/3/webrev/
> 
> I've fixed build warnings in the pkcs11 files
> (make/sun/security/pkcs11/Makefile and
> src/share/classes/sun/security/pkcs11/*.java).
> 
> Please review these changes to pkcs11. (The changes in the other files
> have already been reviewed in this thread.)
> 
I only looked at PKCS11 changes this time. Looks fine to me.

Thanks,
Xuelei

> I would really appreciate a quick review since my internship is almost
> over - I am leaving next week - and I wanted to get this changeset in
> before I leave.
> 
> Thanks,
> Sasha
> 
> On 7/26/2011 10:31 AM, Alexandre Boulgakov wrote:
> 
>     I just noticed that pkcs11 is not built on my machine (64-bit
>     Windows) so I missed all of the warnings there.
> 
>     Thanks,
>     Sasha




More information about the security-dev mailing list