code review request: 7081817, java/classes_secu, test/sun/security/provider/certpath/X509CertPath/IllegalCertiticates.java failing

Xuelei Fan xuelei.fan at oracle.com
Mon Aug 22 11:10:32 UTC 2011


Simple fix, no webrev.

% hg diff src/share/classes/sun/security/provider/certpath/X509CertPath.java
--- a/src/share/classes/sun/security/provider/certpath/X509CertPath.java
+++ b/src/share/classes/sun/security/provider/certpath/X509CertPath.java
@@ -105,7 +105,13 @@
    super("X.509");

    // Ensure that the List contains only X509Certificates
-   for (Certificate obj : certs) {
+   //
+   // Note; The certs parameter is not necessarily to be of Certificate
+   // for some old code. For compatibility, to make sure the exception
+   // is CertificateException, rather than ClassCastException, please
+   // don't use
+   //     for (Certificate obj : certs)
+   for (Object obj : certs)
        if (obj instanceof X509Certificate == false) {
            throw new CertificateException
                ("List is not all X509Certificates: "


Thanks,
Xuelei



More information about the security-dev mailing list