code review request: 7083576 (was Re: no javax/xml/crypto jprt test targets in jdk/test/Makefile)

Weijun Wang weijun.wang at oracle.com
Fri Aug 26 13:42:11 UTC 2011



On 08/26/2011 09:15 PM, Sean Mullan wrote:
> Looks fine though you missed updating the copyright date on the test.

Recently I form a new habit of not touching copyright years at all, so 
that a changeset can be ported to another version with no change at all.

-Max

>
> --Sean
>
> On 8/25/11 9:44 PM, Weijun Wang wrote:
>> [ Add security-dev at openjdk.java.net to CC]
>>
>> I think so. javax/xml/crypto is public API and it should go to
>> jdk_security2 (along with javax/crypto). Of course, that is still not
>> included in the default run.
>>
>> I've filed a bug:
>>
>>      7083576: add javax/xml/crypto into jdk_security2 test rule
>>
>> and here is a webrev:
>>
>>      http://cr.openjdk.java.net/~weijun/7083576/webrev.00
>>
>> Note that one test now uses /othervm because it loads a SecurityManager
>> with its own policy file.
>>
>> JPRT runs fine except that one windows-i586 job is still initializing.
>> Ignored.
>>
>> Thanks
>> Max
>>
>> On 08/26/2011 03:26 AM, Sean Mullan wrote:
>>> I noticed that none of the jprt test targets in test/Makefile run tests in the
>>> javax/xml/crypto directory (i.e. JSR 105 tests) - would that be considered a bug?
>>>
>>> --Sean



More information about the security-dev mailing list