7024771 code review request

Vincent Ryan vincent.x.ryan at oracle.com
Mon Aug 29 05:42:04 PDT 2011


Your fix looks fine.

On 08/26/11 04:38 PM, Sean Mullan wrote:
> Hi Vinnie,
> 
> Could you review the following webrev:
> 
> http://cr.openjdk.java.net/~mullan/webrevs/7024771/webrev.00/
> 
> A couple of notes on the webrev:
> 
> - I have removed support for DNs which use <> as delimiters, ex "<CN=foo>". This
> is an obscure syntax that I have never seen used in practice, and our parser
> wouldn't accept this anyway - we had only partially implemented support for it -
> which was related to the cause of this bug.
> 
> - I have also removed some dead code for strict RFC 1779 parsing. It wasn't
> being used by any other code.
> 
> Thanks,
> Sean




More information about the security-dev mailing list