code review request: 7122169: TcpTimeout fail for various reasons

Weijun Wang weijun.wang at oracle.com
Wed Dec 21 15:01:54 UTC 2011


Great. I'll do that. Let's see if the test ever fails again.

Here is updated webrev:

    http://cr.openjdk.java.net/~weijun/7122169/webrev.02/

Thanks
Max


On 12/21/2011 10:08 PM, Alan Bateman wrote:
> On 21/12/2011 01:52, Weijun Wang wrote:
>>
>> :
>>
>> I'm not sure. The time consumed is from Socket::setSoTimeout(). Do you
>> know if it's connected to clock time (currentTimeMillis) or elapsed
>> time (nanoTime)?
>>
> I think this timeout is specified by elapsed but the implementations use
> JVM_CurrentTimeMillis or in the case of Windows, a timeout provided by
> the kernel. My guess is that if this test is changed to use
> System.currentTimeMillis that it may be more robust but you will need to
> try it.
>
> -Alan
>



More information about the security-dev mailing list