review request for 7008728, update 1: diamond conversion of basic security, permissions, authentication
Stuart Marks
stuart.marks at oracle.com
Sat Jan 8 01:33:21 UTC 2011
Oops! I made this change (and rebuilt and tested) but I forgot to qrefresh
before pushing it, so this didn't actually get in.
Hrmm, well, I guess I'll piggyback this onto one of the other pending changes
in the security area.
Sorry about that Chief,
s'marks
On 1/7/11 3:36 PM, Stuart Marks wrote:
> Great, I'll make this change and push the changeset.
>
> Thanks!
>
> s'marks
>
> On 1/7/11 8:35 AM, Sean Mullan wrote:
>> Hi Stuart,
>>
>> It all looks good to me. One minor comment:
>>
>> Security.java
>>
>> [662]: add a space: s/Map<String,Class>/Map<String, Class>
>>
>> --Sean
>>
>> On 1/6/11 7:16 PM, Stuart Marks wrote:
>>> Hi Sean,
>>>
>>> Here's an updated webrev for 7008728 which we had discussed earlier.
>>>
>>> Basically this webrev includes ONLY changes that use diamond in the initializer
>>> of a variable or field declaration, where the inferred type of the diamond is
>>> right there in the declaration. I've removed all the use of diamond from
>>> assignments, where the declaration (and thus the inferred type) is elsewhere.
>>> I've also removed the use of diamond from the problematic cases that we noted,
>>> such as within the ternary (?:) operator and within method arguments.
>>>
>>> http://cr.openjdk.java.net/~smarks/reviews/7008728/webrev.1/
>>>
>>> Thanks!
>>>
>>> s'marks
More information about the security-dev
mailing list