review request for 7005608, update 1: diamond conversion of JCA and crypto providers

[Bradford Wetmore]

On 1/5/2011 3:57 PM, Stuart Marks wrote:
> Here's an updated webrev for 7005608.
>
> I've removed the changes that use diamond in assignment statements. In
> these cases the variable is declared elsewhere, so using diamond for
> these makes the code somewhat less understandable. I've left in the use
> of diamond for variable initializers (which occur at the point of
> declaration, so the inferred type is right there) and for return
> statements (where the inferred type is the return type of the method).
>
> There were a couple cases where the variable declaration was just a
> "few" lines above the assignment statement, so using diamond wouldn't be
> too bad here. However, I still found myself hunting around a bit for the
> declaration. I also couldn't decide how far away was too far for using
> diamond: 5 lines? 10 lines? In the end, I decided not to use diamond for
> any assignment statements, if only for consistency.

Ok, sounds reasonable.

> Also, I've added a space after the comma in
>
> Map<BigInteger, BlindingParameters>
 >
> at Brad's request.

I could go either way, as long as it's consistent.  <K,V> vs. <K, V> 
looks a little strange, but not as strange as 
Map<BigInteger,BlindingParameters>

But ultimately could get used to either way.

> Note that I did not update the copyright years, as it seems that this
> will be handled by an automated process.

Them's the marching orders we got, so I'll trust it actually works.

> Updated webrev here:
>
> http://cr.openjdk.java.net/~smarks/reviews/7005608/webrev.1/

Looks fine.

Brad