review request for 7008713, update 1: diamond conversion of kerberos5 and security tools

[Stuart Marks]

Hi Max,

Here, finally, is an updated webrev for 7008713. Like the other updates, this 
is the automated diamond conversion but with diamonds removed from assignment 
statements. This is mostly diamonds used in variable initializers. I think 
there's one in a return statement in there too.

I've adjusted whitespace that ended up around the diamond operator itself. I 
think there's a pretty strong convention not to have any space within or around 
a diamond. There are several places where I made changes like the following:

     new HashMap<> ()     ===>     new HashMap<>()

For their webrevs both Sean and Brad had asked me to tweak whitespace after the 
comma in the list of generic type arguments. For example, like the following:

     Map<String,Object>     ===>     Map<String, Object>

However, I did *not* make such changes in this webrev. I didn't know whether 
you would have wanted such changes; there are rather a lot of them to change, 
and it's also not clear to me whether it actually would have improved the 
consistency of the spacing in this section of code. But, let me know if you'd 
like me to adjust this whitespace as well.

Here's a link to the updated webrev.

http://cr.openjdk.java.net/~smarks/reviews/7008713/webrev.1/

Thanks!

s'marks