review request for 7011998: diamond conversion for jgss and pkcs11
Valerie (Yu-Ching) Peng
valerie.peng at oracle.com
Thu Jan 13 03:06:02 UTC 2011
The changes look good to me.
BTW, I recall seeing in one of your earlier email that the byte code is
the same w/ the usage of this diamond operator. Is this so?
If not, then we need to update the sunpkcs11.jar also.
Thanks,
Valerie
On 01/12/11 05:30 PM, Stuart Marks wrote:
> Hi Valerie,
>
> You're up next for diamond conversion. :-)
>
> These should be pretty straightforward. Almost all changes are
> variable initializations. There's one return statement, one use of
> diamond in a ternary operator (a ? b : c), and one whitespace fixup.
>
> Webrev is here:
>
> http://cr.openjdk.java.net/~smarks/reviews/7011998/webrev.0/
>
> Thanks!
>
> s'marks
More information about the security-dev
mailing list