code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

Sean Mullan sean.mullan at oracle.com
Thu Jan 13 16:05:09 UTC 2011


On 1/13/11 6:38 AM, Xuelei Fan wrote:
> Hi Sean,
>
> Would you please review the fix for CR 7011497?
>
> http://cr.openjdk.java.net/~xuelei/7011497/webrev/
>
> Thanks,
> Xuelei

CPValidatorEndEntity.java:

  307         /* coment out useless trust anchor
  308         is = new ByteArrayInputStream(trustAnchor_SHA1withRSA_512.getBytes());
  309         cert = cf.generateCertificate(is);
  310         anchor = new TrustAnchor((X509Certificate)cert, null);
  311         anchors.add(anchor);
  312         */

Why do you leave this code in with this comment?

Otherwise, looks good.

--Sean



More information about the security-dev mailing list