code review request for CR 6989705: ECC security code native code compiler warnings

[Vincent Ryan]

On 21/01/2011 14:42, Alan Bateman wrote:
> Vincent Ryan wrote:
>> Hello Alan,
>>
>> Please review the following webrev which removes 100's of nuisance compiler
>> warnings generated by our ECC code:
>>
>> http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/
>>
>>
>>   
> Getting rid of the #pragmas and the other changes look okay to me. The only
> concern is the Makefile changes to hide the remaining warnings. Would there be
> many changes required to address those so that those warnings can be re-enabled?
> 
> -Alan

The remaining warnings are mostly loss-of-precision warnings - which are safe
to inhibit because they are due to wide data types which have been masked down
to narrower data types before assignment. I'll take another pass through the
code to examine whether any of these warnings can also be eliminated.