Code Review Request for translatability bugs

Weijun Wang weijun.wang at oracle.com
Fri Mar 25 04:15:30 UTC 2011


Another thing, maybe you can also combine the JarSigner TSA-unavailable 
warnings like you did for KeyTool integrity-not-checked ones?

I've attached a diff and you can directly apply it at jdk level.

Thanks
Max


On 03/25/2011 09:35 AM, Weijun Wang wrote:
> AuthResources.java:
> ===================
>
> 1.
>
> {"expected.", "expected "},
> - {".read.end.of.file", ", read end of file"},
> + {"expected.expect.read.end.of.file.",
> + "expected {0}, read end of file"},
>
> The "expected." is now useless. At least I grep thru all jdk/src files
> and see none of it.
>
> 2.
>
> - {"provided.null.name", "provided null name"}
>
> This one is still used in:
>
> ./com/sun/security/auth/SolarisPrincipal.java:79
> ./com/sun/security/auth/SolarisNumericGroupPrincipal.java:92
> ./com/sun/security/auth/SolarisNumericUserPrincipal.java:83
> ./com/sun/security/auth/X500Principal.java:90
>
> There is an entry with the same name in Resources.java, but
> unfortunately our codes use both.
>
>
> Thanks
> Max
>
>
> On 03/25/2011 04:15 AM, Brad Wetmore wrote:
>>
>> On 3/24/2011 6:49 AM, Sean Mullan wrote:
>>> Max, Freda,
>>>
>>> Could you please review this webrev for a batch of translatability bugs:
>>>
>>> http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.00/
>>
>> KeyTool.java:
>> =============
>> Looks good. Only minor comments about line length, which is kind of hard
>> in this environment.
>>
>> Brad
-------------- next part --------------
diff --git a/src/share/classes/sun/security/tools/JarSigner.java b/src/share/classes/sun/security/tools/JarSigner.java
--- a/src/share/classes/sun/security/tools/JarSigner.java
+++ b/src/share/classes/sun/security/tools/JarSigner.java
@@ -1238,8 +1238,6 @@
                 // Provide a helpful message when TSA is beyond a firewall
                 error(rb.getString("unable.to.sign.jar.") +
                 rb.getString("no.response.from.the.Timestamping.Authority.") +
-                rb.getString("When.connecting.from.behind.a.firewall.an.HTTP.or.HTTPS.proxy.may.need.to.be.specified.") +
-                rb.getString("Supply.the.following.options.to.jarsigner.") +
                 "\n  -J-Dhttp.proxyHost=<hostname>" +
                 "\n  -J-Dhttp.proxyPort=<portnumber>\n" +
                 rb.getString("or") +
diff --git a/src/share/classes/sun/security/tools/JarSignerResources.java b/src/share/classes/sun/security/tools/JarSignerResources.java
--- a/src/share/classes/sun/security/tools/JarSignerResources.java
+++ b/src/share/classes/sun/security/tools/JarSignerResources.java
@@ -181,11 +181,9 @@
         {"TSA.location.", "TSA location: "},
         {"TSA.certificate.", "TSA certificate: "},
         {"no.response.from.the.Timestamping.Authority.",
-                "no response from the Timestamping Authority. "},
-        {"When.connecting.from.behind.a.firewall.an.HTTP.or.HTTPS.proxy.may.need.to.be.specified.",
-                "When connecting from behind a firewall an HTTP or HTTPS proxy may need to be specified. "},
-        {"Supply.the.following.options.to.jarsigner.",
-                "Supply the following options to jarsigner: "},
+                "no response from the Timestamping Authority. When connecting"
+                + " from behind a firewall an HTTP or HTTPS proxy may need to"
+                + " be specified. Supply the following options to jarsigner:"},
         {"or", "or"},
         {"Certificate.not.found.for.alias.alias.must.reference.a.valid.KeyStore.entry.containing.an.X.509.public.key.certificate.for.the",
                 "Certificate not found for: {0}.  {1} must reference a valid KeyStore entry containing an X.509 public key certificate for the Timestamping Authority."},


More information about the security-dev mailing list