code review request: 7031536: test/sun/security/krb5/auto/HttpNegotiateServer.java should not use static ports

Xuelei Fan xuelei.fan at oracle.com
Mon Mar 28 09:22:29 UTC 2011


On 3/28/2011 4:23 PM, Weijun Wang wrote:
> Hi Xuelei
>
> This webrev includes 2 kinds of code changes:
>
>    http://cr.openjdk.java.net/~weijun/7031536/webrev.00/
>
> 1. HttpNegotiateServer: now servers open on port 0.
Looks fine.
>
> 2. Others: I add run/othervm for all tests in jgss and krb5 that call 
> System.setProperty
>
As it only impact the test cases, I did not look into the code very 
carefully. There is no bad impact to add the "run/othervm" for all test. 
So generally, those update looks good to me, too.


Xuelei

> Thanks
> Max
>
>
> -------- Original Message --------
> *Change Request ID*: 7031536
>
> *Synopsis*: test/sun/security/krb5/auto/HttpNegotiateServer.java 
> should not use static ports
>
>
> === *Description* 
> ============================================================
> test/sun/security/krb5/auto/HttpNegotiateServer.java uses static port 
> numbers when starting web and proxy servers. If another process uses 
> the same ports, test would fail.
>




More information about the security-dev mailing list