code review request: 7040916: DynamicKeyTab test fails on Windows

Xuelei Fan xuelei.fan at oracle.com
Sun May 1 06:00:37 UTC 2011


Looks  fine to me.

Xuelei

On 5/1/2011 10:05 AM, Weijun Wang wrote:
> Hi Andrew
>
> http://cr.openjdk.java.net/~weijun/7040916/webrev.00/
>
> The keytab file cannot be removed and the test fails. The file was 
> opened twice and both not closed:
>
>   1. once inside the test
>   2. once inside KeyTab and not closed because it's not a valid keytab
>
> Also, I change File.delete() calls inside the test to new NIO2 calls 
> so that if it cannot be removed an exception will be thrown.
>
> Thanks
> Max
>
>
> -------- Original Message --------
> *Change Request ID*: 7040916
> *Synopsis*: DynamicKeyTab test fails on Windows
>
>
> === *Description* 
> ============================================================
> An invalid keytab FileInputStream is not closed and therefore cannot 
> be removed on Windows.
>
> *** (#1 of 1): 2011-05-01 01:55:22 GMT+00:00 weijun.wang at oracle.com
>
> === *Evaluation* 
> =============================================================
> Should close the stream no matter if the content is valid or not.
>
> *** (#1 of 1): 2011-05-01 01:56:36 GMT+00:00 weijun.wang at oracle.com
>
>




More information about the security-dev mailing list