updated code review request: 7099399: cannot deal with CRL file larger than 16MB

Weijun Wang weijun.wang at oracle.com
Thu Oct 13 11:33:36 PDT 2011



On 10/13/2011 2:10 AM, Florian Weimer wrote:
> * Seán Coffey:
>
>> Should this test be set to run manually ?
>>
>> 5 mins is far too long for a jtreg unit test IMO.

Sorry, I was talking about the whole time for the job. I just go into 
each log to take a look at the exact time for the test itself. Most are 
less than 20 seconds, except for 3 solaris-sparc platforms, which are 
105, 51 and 57 seconds. I guess this is still OK.

>
> If the visibility of the internal helper method is changed, you could
> test with a custom InputStream and ByteArrayOutputStream, which would
> cut down memory requirements.
>

Probably. Also, if required memory can be brought down, hopefully it 
will also decrease time.

Thanks
Max



More information about the security-dev mailing list