Code Review Needed: 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine

Brad Wetmore bradford.wetmore at oracle.com
Sat Oct 15 00:52:30 UTC 2011


Hi Xuelei,

I need code reviews for the bug I mentioned to you earlier.

7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine

The MAC calculation was summing the wrong data range when using 
non-direct byte buffers and TLS1.1/1.2.

The new regression test will now interop-test SSLEngine with SSLSockets 
using both direct and non-direct ByteBuffers, over SSLv3, TLSv1, 
TLSv1.1, and TLSv1.2.

http://cr.openjdk.java.net/~wetmore/7031830/

I plan to push this to both JDK 8 and 7u2, so there are 2 webrevs there. 
  They should be the same.

Brad



More information about the security-dev mailing list