Code review request for 7049079: NTSYSTEM CLASS IS LEAKING 3 WINDOWS TOKENS

Weijun Wang weijun.wang at oracle.com
Fri Sep 2 22:34:42 PDT 2011


The code change looks fine.

Thanks
Max

On 09/02/2011 11:15 PM, Seán Coffey wrote:
> This is a forward port to JDK 8 of a fix gone into jdk 5 and jdk6 releases.
> It'll be ported to 7u shortly after jdk8.
>
> Bug id is not public.
>
> NTSystem() obtains a native Token instance for each constructor call.
> This is unnecessary and Token instances should only be requested when
> called for, i.e. at getImpersonationToken() time.
>
> No auto testcase but fix has been verified though use of the MS handle
> tool and a simple java testcase.
>
> http://cr.openjdk.java.net/~coffeys/webrev.7049079.jdk8/
>
> Regards,
> Sean.



More information about the security-dev mailing list