code review request: 7091290: fails to build jdk8 b05 Embedded build

[David Holmes]

Hi Max,

On 20/09/2011 1:57 PM, Weijun Wang wrote:
> Code change
>
> http://cr.openjdk.java.net/~weijun/7091290/webrev.00/

Looks good to me. (Initially I mis-parsed the casts)

David
-----

> Normally, Oid.java is compiled when compiling SSL (sun/security/ssl) and
> deprecation warning is not treated as error there. In some increment builds,
> it might be compiled along with jgss codes, where deprecated warning is an
> error.
>
> No regression tests, build issue.
>
> How to verify: after JDK is built, remove files in classes/org/ietf/jgss/
> and classes/sun/security/jgss/, go into make/sun/security and call make.
>
> Thanks
> Max
>
> -------- Original Message --------
> *Change Request ID*: 7091290
> *Synopsis*: fails to build jdk8 b05 Embedded build
>
>
> === *Description* ============================================================
> # Running javac:
> /java/re/jdk/1.7.0/archive/fcs/binaries/linux-i586/bin/java
> -XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -client
> -Xmx512m -Xms512m -XX:PermSize=32m -XX:MaxPermSize=160m
> -Xbootclasspath/p:/HUDSON/workspace/embedded-jdk7/ws/builds/b05/linux-i586-ea/langtools/dist/bootstrap/lib/javac.jar
> -jar
> /HUDSON/workspace/embedded-jdk7/ws/builds/b05/linux-i586-ea/langtools/dist/bootstrap/lib/javac.jar
> -Werror -Xlint:all -Xlint:-path -source 7 -target 7 -encoding ascii
> -Xbootclasspath:/HUDSON/workspace/embedded-jdk7/ws/builds/b05/linux-i586-ea/classes
> -sourcepath
> ../../../../src/closed/solaris/classes:../../../../src/closed/share/classes:/HUDSON/workspace/embedded-jdk7/ws/builds/b05/linux-i586-ea/gensrc:../../../../src/solaris/classes:../../../../src/share/classes
> -d /HUDSON/workspace/embedded-jdk7/ws/builds/b05/linux-i586-ea/classes
> @/HUDSON/workspace/embedded-jdk7/ws/builds/b05/linux-i586-ea/tmp/sun/sun.security.jgss/.classes.list.filtered
>
> ../../../../src/share/classes/org/ietf/jgss/Oid.java:160: warning:
> [deprecation] equals(ObjectIdentifier) in ObjectIdentifier has been deprecated
> return this.oid.equals(((Oid) other).oid);
> ^
> error: warnings found and -Werror specified
> 1 error
> 1 warning
> make[5]: *** [.compile.classlist] Error 1
> make[5]: Leaving directory
> `/HUDSON/workspace/embedded-jdk7/ws/jdk/make/sun/security/jgss'
> make[4]: *** [all] Error 1
> make[4]: Leaving directory
> `/HUDSON/workspace/embedded-jdk7/ws/jdk/make/sun/security'
> make[3]: *** [all] Error 1
> make[3]: Leaving directory `/HUDSON/workspace/embedded-jdk7/ws/jdk/make/sun'
> make[2]: *** [all] Error 1
> make[2]: Leaving directory `/HUDSON/workspace/embedded-jdk7/ws/jdk/make'
> make[1]: *** [jdk-build] Error 2
> make[1]: Leaving directory `/HUDSON/workspace/embedded-jdk7/ws'
> make: *** [build_product_image] Error 2
> Notifying upstream projects of job completion
> Finished: FAILURE