JDK 8 Code Review Request for 7152564 and 7155693

Chris Hegarty chris.hegarty at oracle.com
Fri Apr 6 07:36:25 PDT 2012


On 06/04/12 15:16, Sean Mullan wrote:
> On 4/6/12 10:13 AM, Sean Mullan wrote:
>> On 4/6/12 9:59 AM, Seán Coffey wrote:
>>> Looks good Sean. Thanks for taking care of jdk 8 changes.
>>>
>>> Hopefully someone else can also review since I'm not an official jdk 8
>>> reviewer.
>>
>> Ok. Copying Chris to see if he could also review.

The changes look good to me too. Thanks for doing this.

-Chris

> Oops, missed him on the cc. Let me try that again.
>
> --Sean
>
>>
>> Thanks,
>> Sean
>>
>>>
>>> regards,
>>> Sean.
>>>
>>> On 06/04/12 14:40, Sean Mullan wrote:
>>>> Hi Sean,
>>>>
>>>> Can you please review the code changes for the following bugs:
>>>>
>>>> 7152564: Improve CodeSource.matchLocation(CodeSource) performance
>>>> 7155693: CodeSource.matchLocation getPort test can be improved
>>>>
>>>> webrev: http://cr.openjdk.java.net/~mullan/webrevs/7152564_7155693/webrev.00/
>>>>
>>>> I will finalize the CCC request after your code review.
>>>>
>>>> (Note that if you click on the link for 7152564 in the webrev, it says the bug
>>>> is closed/not a defect, because it was misfiled on an invalid release. But there
>>>> is actually a valid corresponding MR for JDK 8:
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=2222764).
>>>>
>>>> Thanks,
>>>> Sean



More information about the security-dev mailing list