[8] Code Review Request for 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile

Mandy Chung mandy.chung at oracle.com
Fri Dec 21 22:02:24 UTC 2012


On 12/19/2012 1:35 PM, Sean Mullan wrote:
> For JEPs 161 and 162, we need to remove or deprecate undesirable 
> dependencies from the compact1 profile.
>
> One of these is the dependency on 
> com.sun.security.auth.login.ConfigFile from 
> sun.security.provider.ConfigSpiFile.
>
> The proposed fix moves the guts of the ConfigFile implementation to 
> sun.security.provider.ConfigSpiFile, and changes ConfigFile such that 
> it is simply a wrapper around ConfigSpiFile.
>
> webrev: http://cr.openjdk.java.net/~mullan/webrevs/8005117/webrev.00/

This looks good to me from what I can tell and it's good to see the code 
be modernized to use some new language features.

Thanks for removing this dependency.
Mandy



More information about the security-dev mailing list