code review request: 7133068: java.security code comments have issues with Accessibility compliance

Sean Mullan sean.mullan at oracle.com
Tue Feb 28 07:04:56 PST 2012


Looks ok to me but I'm also copying Sowmya to see if she could review this.

Thanks,
Sean

On 2/26/12 10:18 PM, Weijun Wang wrote:
> Hi All
> 
> Please review this code change
> 
>     http://cr.openjdk.java.net/~weijun/7133068/webrev.00/
> 
> Basically, for a nice accessibility compliance, a TABLE needs a 
> "summary" attribute, a TH needs an "id", and then a TH needs a "headers" 
> that links to its corresponding TD. (By headers I guess it's because a 
> COLSPAN TD can have multiple corresponding THs).
> 
> The same patch applies to both JDK 8 and 7u.
> 
> Thanks
> Max
> 
> 
> -------- Original Message --------
> Subject: CR 7133068 Updated, P3 java/classes_secu java.security code 
> comments have issues with Accessibility compliance
> Date: Wed, 15 Feb 2012 23:21:22 -0700 (MST)
> From: weijun.wang at oracle.com
> To: yulian.xu at oracle.com, artem.smotrakov at oracle.com, 
> ludmila.shikhvarg at oracle.com, weijun.wang at oracle.com, 
> mala.bankal at oracle.com, nithya.srinivasan at oracle.com, 
> xuelei.fan at oracle.com
> 
>                          Sun Confidential: Internal only
> 
> *Synopsis*: java.security code comments have issues with Accessibility 
> compliance
> 
> Bugster: 
> http://bt2ws.central.sun.com/loadcr.jnlp?jnlp_url=http://bugster.central.sun.com/&arg=7133068
> CrPrint: http://bt2ws.central.sun.com/CrPrint?id=7133068
> Monaco: http://monaco.us.oracle.com/detail.jsf?cr=7133068
> 
> CR 7133068 changed on Feb 16 2012 by weijun.wang at oracle.com
> 
> === Field ============ === New Value ============= === Old Value 
> =============
> 
> Comments               New Note 
> 
> Status                 3-Accepted                  1-Dispatched 
> 
> ====================== =========================== 
> ===========================
> 
> 
> *Change Request ID*: 7133068
> 
> *Synopsis*: java.security code comments have issues with Accessibility 
> compliance
> 
>    Product: java
>    Category: java
>    Subcategory: classes_security
>    Type: Defect
>    Subtype:
>    Status: 3-Accepted
>    Substatus:
>    Priority: 3-Medium
>    Introduced In Release:
>    Introduced In Build:
>    Responsible Manager: frances.ho at oracle.com
>    Responsible Engineer: weijun.wang at oracle.com
>    Initial Evaluator: jsn-sec-bugs at sun.com
>    Keywords: oghag
> 
> === *Description* 
> ============================================================
> API files for this bug are from packages:api.java.security, 
> api.java.security.acl, api.java.security.cert, 
> api.java.security.interfaces, api.java.security.spec and included in jar 
> available at 
> http://jsqalab.us.oracle.com/results/JDKCompatibility/Accessibility/7u4/b225/jar_files/java_security.jar
> Accessibility report: 
> http://jsqalab.us.oracle.com/results/JDKCompatibility/Accessibility/7u4/b225/report_files/java_security.htm
> 
> Tested with 7u4 b225
> 
> *** (#1 of 1): 2012-01-25 00:13:36 GMT+00:00 ludmila.shikhvarg at oracle.com
> 
> 
> === *Public Comments* 
> ========================================================
> 
> === *Comments* 
> ===============================================================
> This seems to be a false alarm:
> 
>  
> http://oac-v2.us.oracle.com/report.jsp?p_action=URLRun&p_urlrunid=25780113
> 
> The link here is <a 
> href="../../java/io/FilterInputStream.html#skip(long)">. Looks like the 
> validator mistakenly treated it as a skipping repetitive navigation link 
> because there is a word "skip" in the link.
> 
> *** (#1 of 1): 2012-02-16 06:10:52 GMT+00:00 weijun.wang at oracle.com
> 
> 
> === *Evaluation* 
> =============================================================
> 
> === *Suggested Fix* 
> ==========================================================
> 
> === *Workaround* 
> =============================================================
> 
> === *Justification* 
> ==========================================================
> Priority changed from [] to [3-Medium]
> java.security code comments have issues with Accessibility compliance
> ludmila.shikhvarg at oracle.com 2012-01-25 00:13:36 GMT
> 
> *** (#1 of 1): 2012-01-25 00:13:36 GMT+00:00 ludmila.shikhvarg at oracle.com
> 
> 
> === *Additional Details* 
> =====================================================
>          Targeted Release:
>          Commit To Fix In Build:
>          Fixed In Build:
>          Integrated In Build:
>          Verified In Build:
>    See Also:
>    Duplicate of:
>    Hooks:
>          Hook1:
>          Hook2:
>          Hook3:
>          Hook4:
>          Hook5:
>          Hook6:
>    Interest List:
>    Program Management:
>    Root Cause:
>    Is a Security Vulnerability?: No
>    Fix Affects Documentation: No
>    Fix Affects Localization: No
>    Reported by:
> 
> === *History* 
> ================================================================
>          Date Submitted: 2012-01-25 00:13:36 GMT+00:00
>          Submitted By: ludmila.shikhvarg at oracle.com
> 
>          Status Changed    Date Updated                  Updated By
>          3-Accepted        2012-02-16 06:11:01 GMT+00:00 
> weijun.wang at oracle.com
> 
> 
> === *Solution* 
> ===============================================================
> 
> 
> === *Service Request* 
> ========================================================
>          ID: 1-787886406
>      	Customer:
>          Account Name: Oracle Corporation
>          Customer Contact: javase-sqe
>          Customer Contact Role: S-System Test
>          Customer Contact Type: I-Internal (SMI) Customer
>          Impact: Significant
>          Functionality: Secondary
>          Severity: 3
>          Synopsis:
>          Product Name: java
>          Product Release: 7u4
>          Product Build:
>          Operating System: generic
>          Hardware: generic
>          Reference Number:
>          Sun Contact: ludmila.shikhvarg at oracle.com
>          Status: Open
>          Source: BugTraq2
>          Reproducible:
>          Submitted By: ludmila.shikhvarg at oracle.com
>          Submitted Date: 2012-01-25 00:13:36 GMT+00:00
>          Description:
> 
> 
> === *Activity* 
> ===============================================================
> 
> 
> === *Multiple Release (MR) Cluster* - 0 
> ======================================
> 
> 
> === *Escalations* 
> ============================================================
> 



More information about the security-dev mailing list