7u Code review request for 7033170, 7092821, 7092825

Valerie (Yu-Ching) Peng valerie.peng at oracle.com
Wed Jan 11 17:04:57 PST 2012


Sean,

I need to backport 7033170 to 7u4. It's the exact same set of changes 
that you've reviewed for JDK8.
Also, performance team find some performance bottlenecks when running 
against SPECjvm and requested the 2 performance bugs be addressed for 
7u4. I've made slight changes to what they suggested and applied them to 
both JDK8 and 7u. Can you please take a look?

7033170: Cipher.getMaxAllowedKeyLength(String) throws 
NoSuchAlgorithmException
jdk7u Weberv: http://cr.openjdk.java.net/~valeriep/7033170_7u/

7092821: java.security.Provider.getService() is synchronized and became 
scalability bottleneck.
jdk7u Webrev: http://cr.openjdk.java.net/~valeriep/7092821_7u/
jdk8 Webrev: http://cr.openjdk.java.net/~valeriep/7092821/

7092825: javax.crypto.Cipher.Transform.patternCache is synchronizedMap 
and became scalability bottleneck.
jdk7u Webrev: http://cr.openjdk.java.net/~valeriep/7092825_7u/
jdk8 Webrev: http://cr.openjdk.java.net/~valeriep/7092825/

Thanks,
Valerie



More information about the security-dev mailing list