JDK8 Code review request for 7133344: Document the java.security.properties system property feature in the java.security file

Sean Mullan sean.mullan at oracle.com
Tue Jul 3 11:58:17 PDT 2012


Looks good. I'll push the changeset for you.

--Sean

On 7/3/12 2:28 PM, Jason Uh wrote:
> Thanks, Max and Sean.
> 
> Now with the empty line: http://cr.openjdk.java.net/~juh/7133344/webrev.02/
> 
> Jason
> 
> On 07/03/2012 05:00 AM, Sean Mullan wrote:
>> On 7/3/12 7:57 AM, Weijun Wang wrote:
>>> The current line 25 has a "#" and I prefer it to be a real empty line.
>>
>> Ok, I understand now. Yes, I agree that would be a good change.
>>
>> --Sean
>>
>>>
>>> -Max
>>>
>>> On 07/03/2012 07:49 PM, Sean Mullan wrote:
>>>> On 7/2/12 11:14 PM, Weijun Wang wrote:
>>>>> One minor thing:
>>>>>
>>>>> Line 25 should be empty, this starts another paragraph on providers.
>>>>
>>>> I'm not sure I understand the comment as it is empty already.
>>>>
>>>> --Sean
>>>>
>>>>>
>>>>> Thanks
>>>>> Max
>>>>>
>>>>> On 07/03/2012 01:34 AM, Sean Mullan wrote:
>>>>>> Yep, looks good.
>>>>>>
>>>>>> On 07/02/2012 11:59 AM, Tom Hawtin wrote:
>>>>>>> Looks good.
>>>>>>>
>>>>>>> Tom
>>>>>>>
>>>>>>> On 02/07/2012 16:54, Jason Uh wrote:
>>>>>>>> Thanks for your comments.
>>>>>>>>
>>>>>>>> Please see updated webrev:
>>>>>>>> http://cr.openjdk.java.net/~juh/7133344/webrev.01
>>>>>>>>
>>>>>>>> Jason
>>>>>>>>
>>>>>>>> On 07/02/2012 08:45 AM, Tom Hawtin wrote:
>>>>>>>>> On 02/07/2012 16:00, Jason Uh wrote:
>>>>>>>>>
>>>>>>>>>> This change is documentation for allowing a user to specify an
>>>>>>>>>> alternate
>>>>>>>>>> java.security file.
>>>>>>>>>>
>>>>>>>>>> Webrev: http://cr.openjdk.java.net/~juh/7133344/webrev.00/
>>>>>>>>>> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7133344
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> +# An alternate java.security properties file may be specified
>>>>>>>>> +# from the command line via the system property
>>>>>>>>> +#
>>>>>>>>> +# java.security.properties=<URL>
>>>>>>>>>
>>>>>>>>> I think that should be:
>>>>>>>>>
>>>>>>>>> +# -Djava.security.properties=<URL>
>>>>>>>>>
>>>>>>>>> Tom
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>




More information about the security-dev mailing list