JDK8 Code review request for 7026347: Certificate and X509CRL should have verify(PublicKey key, Provider sigProvider)

Xuelei Fan xuelei.fan at oracle.com
Fri Jul 20 00:20:49 PDT 2012


I was wondering, for better compatibility with previous providers, it
may be considerable to make use of the existing APIs as the
implementation of Certificate.verify(PublicKey key, Provider sigProvider):

     public void verify(PublicKey key, Provider sigProvider)
         throws CertificateException, NoSuchAlgorithmException,
         InvalidKeyException, SignatureException {
-         throw new UnsupportedOperationException();
+         verify(key, sigProvider.getName());
     }

As may simplify both the spec and implementation.

Xuelei

On 7/20/2012 1:03 PM, Jason Uh wrote:
> Hi all,
> 
> Please review my fix for 7026347.
> 
> This change is introduces verify(PublicKey key, Provider sigProvider)
> methods for Certificate and X509CRL that allow Providers not registered
> in java.security. Change has been filed with CCC and is accepted.
> 
> Webrev: http://cr.openjdk.java.net/~juh/7026347/webrev.03/
> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7026347
> 
> Thanks,
> Jason




More information about the security-dev mailing list