Code review request: 7187051: ShortRSAKeynnn.sh tests should do cleanup before start tes

Xuelei Fan xuelei.fan at oracle.com
Thu Jul 26 03:36:57 PDT 2012


Looks fine to me.

Xuelei

On 7/26/2012 4:41 PM, Weijun Wang wrote:
> Hi Xuelei
> 
> You might have to review the fix to the same test again
> 
>   http://cr.openjdk.java.net/~weijun/7187051/webrev.00/
> 
> This time it's
> 
>   7187051 ShortRSAKeynnn.sh tests should do cleanup before start test
> 
> Thanks
> Max
> 
> On 07/17/2012 10:35 AM, Xuelei Fan wrote:
>> Looks fine to me.  Thanks for addressing this issue.
>>
>> Xuelei
>>
>> On 7/16/2012 6:23 PM, Weijun Wang wrote:
>>> Hi Xuelei
>>>
>>> The ShortRSAKeyNNN tests have failed several times recently, showing
>>> strange error messages like "Signature not verified" or "Cannot create
>>> key" for the keytool command. It might be some internal MSCAPI problem
>>> but I'm not sure.
>>>
>>> Therefore I'm adding a "-debug" option to keytool calls. Also, it looks
>>> to me these tests are almost identical, so I've consolidated them into
>>> one. Please take a review:
>>>
>>>     http://cr.openjdk.java.net/~weijun/7183203/webrev.00/
>>>
>>> Thanks
>>> Max
>>>
>>>
>>> -------- Original Message --------
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7183203
>>>
>>> 7183203: ShortRSAKeynnn.sh tests intermittent failure
>>>
>>>    Product: java
>>>    Category: java
>>>    Subcategory: classes_security
>>>    Type: Defect
>>>
>>> === *Description*
>>> ============================================================
>>> sun/security/mscapi/ShortRSAKey1024.sh
>>> sun/security/mscapi/ShortRSAKey768.sh
>>> sun/security/mscapi/ShortRSAKey512.sh
>>>
>>> We are seeing these tests intermittent failure recently. Error is on
>>> keytool -genkeypair command, sometimes "Bad key" sometimes "Invalid
>>> signature".
>>>
>>> Not sure if it's an MSCAPI problem or multiple tests are modifying
>>> Windows-MY at the same time. This CR intends to add more debug info and
>>> combine the tests into one that run consequently.
>>>
>>
>>




More information about the security-dev mailing list