Code Review Request for 7107613, 7107616, 7185471

Valerie (Yu-Ching) Peng valerie.peng at oracle.com
Thu Jul 26 18:31:04 UTC 2012


Yes, I find the definition for rounds seems inconsistent in the original 
code, so I did a little clean up.
Valerie

On 07/25/12 19:15, Weijun Wang wrote:
>> http://cr.openjdk.java.net/~valeriep/7185471
>
> Looks fine, but I want to confirm if my understanding is correct:
>
> 1. I guess ROUNDS being 10, 12 and 14 means keysize of of 128, 192, 256?
>
> 2. The original code has confused ROUNDS and key length a little, so 
> the line
>
>    57     /** (ROUNDS-1) * 4 */
>
> was incorrect. You've fixed this and used different names for them.
>
> Thanks
> Max
>
>
>>
>> The changes are for JDK 8. May be backported to 7u later if necessary,
>> Thanks,
>> Valerie




More information about the security-dev mailing list